TLS/ACM: Add walk through #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dastbe
reviewed
Aug 6, 2019
dastbe
reviewed
Aug 6, 2019
| @@ -0,0 +1,30 @@ | |||
| # Gopkg.toml example | |||
There was a problem hiding this comment.
nit: remove the example configuration?
| # unused-packages = true | ||
|
|
||
|
|
||
| [prune] |
There was a problem hiding this comment.
Given we're using dep, should we gitignore the vendor directory? A thought that I'm fine with being overridden on.
There was a problem hiding this comment.
I think as a follow-up we can remove it. The dependency list is fairly small so I'm not terribly worried about reproducability of builds for these, and would prefer a cleaner repo myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-app-mesh-roadmap#38
aws/aws-app-mesh-roadmap#39
Dependent upon aws/aws-app-mesh-roadmap#90
Description of changes:
Add a walk through for how to use TLS with App Mesh and AWS Certificate Manager (ACM).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.